Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorHandler segfaults when provided a mlir::FusedLoc #875

Open
philipportner opened this issue Oct 23, 2024 · 0 comments
Open

ErrorHandler segfaults when provided a mlir::FusedLoc #875

philipportner opened this issue Oct 23, 2024 · 0 comments
Labels
bug A mistake in the code. good first issue Non-urgent, simple task with limited scope, suitable for getting started as a contributor.

Comments

@philipportner
Copy link
Collaborator

See #874 , part of the stack trace from there:

#0  0x00000000020f3293 in mlir::FileLineColLoc::getFilename() const ()
#1  0x000000000162bda9 in ErrorHandler::compilerError(mlir::Location, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
#2  0x000000000162c5fd in ErrorHandler::compilerError(mlir::Operation*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
#3  0x00000000016a0235 in VectorizedPipelineOpLowering::matchAndRewrite(mlir::daphne::VectorizedPipelineOp, mlir::daphne::VectorizedPipelineOpAdaptor, mlir::ConversionPatternRewriter&) const ()
#4  0x0000000001688273 in mlir::OpConversionPattern<mlir::daphne::VectorizedPipelineOp>::matchAndRewrite(mlir::Operation*, llvm::ArrayRef<mlir::Value>, mlir::ConversionPatternRewriter&) const ()

The stack trace displays what happens when the ErrorHandler is passed an instance of mlir::FusedLoc, instead of an instance of mlir::FileLineColLoc as it casts the provided loc without any checks.

@philipportner philipportner added bug A mistake in the code. good first issue Non-urgent, simple task with limited scope, suitable for getting started as a contributor. labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A mistake in the code. good first issue Non-urgent, simple task with limited scope, suitable for getting started as a contributor.
Projects
None yet
Development

No branches or pull requests

1 participant