Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convience methods for skipping library deployment #881

Open
MrChico opened this issue Dec 7, 2021 · 1 comment · May be fixed by #884
Open

convience methods for skipping library deployment #881

MrChico opened this issue Dec 7, 2021 · 1 comment · May be fixed by #884
Labels
good first issue Good for newcomers

Comments

@MrChico
Copy link
Member

MrChico commented Dec 7, 2021

deploying libraries can take a long time. One can easily skip this stage if we make it possible to save the deployed library state and pass it to dapp test:

  1. Write a new little dapp helper script which is the dapp --library-addresses above
  2. Make dapp build and dapp --make-library-state use this helper script instead
  3. Allow a flag --state to be passed to dapp test (probably along with env var DAPP_TEST_STATE), which would override the default behaviour of the library deployment that happens automatically

Now if you want to cache this annoying 45s process that happens everytime, you would put:

export DAPP_LIBRARIES=$(dapp --library-addresses)
export DAPP_TEST_STATE=$(dapp --make-library-state)

in your makefile

@MrChico MrChico added the good first issue Good for newcomers label Dec 7, 2021
@MrChico
Copy link
Member Author

MrChico commented Dec 7, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant