Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add support for or filters #271

Open
luke-rogers opened this issue Jun 8, 2023 · 0 comments
Open

feature request: add support for or filters #271

luke-rogers opened this issue Jun 8, 2023 · 0 comments

Comments

@luke-rogers
Copy link
Contributor

In version 9.18, firebase added support for or queries.

From this PR we can see it has been made available via a new query method with the signature query<T>(query: Query<T>, compositeFilter: QueryCompositeFilterConstraint, ...queryConstraints: QueryNonFilterConstraint[]).

Introduction of the new QueryCompositeFilterConstraint type means its incompatible with the current signatures of syncCollection, syncCollectionGroup, and valueChanges and as such or queries cannot be used.

I'd be interested to hear some opinions on the proposed method signatures as there is quite a bit of overloading already going on.

Happy to have a go at adding support if we can agree on the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant