Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries for OfflinePlayers from Mojang in Main Thread #59

Open
Joo200 opened this issue May 6, 2022 · 3 comments
Open

Queries for OfflinePlayers from Mojang in Main Thread #59

Joo200 opened this issue May 6, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@Joo200
Copy link

Joo200 commented May 6, 2022

Original issue: NuVotifier/NuVotifier#301

Looks like the call to get the offline player from mojang might be a problem.
https://github.com/darbyjack/VoteParty/blob/966d121771f6df0cb68a4221b9ed54a1de48f4e2/src/main/kotlin/me/clip/voteparty/listener/HooksListenerNuVotifier.kt

Better implement the Paper's PlayerProfile API here to avoid sync calls on the main thread.

@darbyjack
Copy link
Owner

darbyjack commented May 8, 2022

Does Paper have a fallback when it's on Spigot? If so, I can utilize this. Also, it's unreleased but the latest commit should already help improve this.

Edit: If this utilizes Paper API I don't think this will work out because it throws errors when utilized on Spigot.

@audicu707
Copy link

When can we get latest commit available on spigot?

@darbyjack
Copy link
Owner

There has been some improvements to this since this discussion. While it still may happen rarely, it should be way less often. I'm still open to options that still support Spigot.

@darbyjack darbyjack added the help wanted Extra attention is needed label Mar 19, 2023
@darbyjack darbyjack pinned this issue Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants