Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deploy from killing old CronChecker deployment until the new one is in place #3671

Closed
pbiggar opened this issue Apr 11, 2022 · 3 comments

Comments

@pbiggar
Copy link
Member

pbiggar commented Apr 11, 2022

A deploy failed earlier today.

The major issue that happened is that CronChecker went down and crons had a minor outage for about 15 minutes. This is because CronChecker's deployment policy is ReCreate, because we can't have two things running the cronchecker at once. To solve this, we should allow the old and the new cronchecker to run at once, with some sort of lock/semaphore in the DB, pub sub, cloud storage, etc.

@StachuDotNet
Copy link
Member

Is still of a concern? if so, can we please re-title this?

@pbiggar pbiggar changed the title address failed deploy of Apr 11 Prevent deploy from killing old CronChecker deployment until the new one is in place Jun 22, 2022
@pbiggar
Copy link
Member Author

pbiggar commented Jun 22, 2022

This will be solved when CronChecker is removed. (if somehow we decide not to remove CronChecker, this issue is still important)

@StachuDotNet
Copy link
Member

merged into #5261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants