Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial publish of ok_http and firehose setup #1259

Open
brianquinlan opened this issue Jul 10, 2024 · 8 comments · May be fixed by #1286
Open

Initial publish of ok_http and firehose setup #1259

brianquinlan opened this issue Jul 10, 2024 · 8 comments · May be fixed by #1286
Assignees

Comments

@brianquinlan
Copy link
Collaborator

brianquinlan commented Jul 10, 2024

@Anikate-De @camsim99

@brianquinlan brianquinlan changed the title Enable firehouse for package:http Enable firehouse for package:http to enable automatic publishing Jul 10, 2024
@camsim99
Copy link

@natebosch Hi! @Anikate-De is close to finishing the implementation for ok_http so we will be looking to publish soon. Brian mentioned possibly (me) needing access to the labs publisher which I assume is related to this issue (I am unfamiliar with the publishing process for Dart packages). Is there anything I can do here?

@natebosch
Copy link
Member

Since this package hasn't been published, we might need to do the first publish manually. @devoncarew Have we ever used firehose to bootstrap a previously unpublished package? Should we try it and see if it works, or should I publish manually?

I think we can't set up the protected environment for example before the package exists.
https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose#publishing-from-a-protected-github-environment

Maybe it's safe to set up the GitHub side and then configure pub after the first publish?

@devoncarew
Copy link
Member

I'm not sure it's possible to bootstrap using firehose. I think you have to publish once (manually) then move the package into the target publisher, and use the package admin page to enable publishing-via-github.

I've only lightly used the publishing w/ an environment feature; I don't think it gets us the two-party review thing that we'd want, and adds another step to publishing. I'd recommend just avoiding it unless it adds more than I'm aware of.

@natebosch
Copy link
Member

Oh, I must have forgot that this already happened.
https://github.com/dart-lang/http/blob/master/.github/workflows/publish.yaml

It looks like firehose doesn't support flutter packages though.

@camsim99
Copy link

It looks like firehose doesn't support flutter packages though.

Oh interesting so after you do the first manual publish, we will have to continue to manually publish for every new version?

@natebosch
Copy link
Member

I think I'll just need to split the workflow up into two separate ones for the flutter and non-flutter packages. It looks like firehose has a config option for this.

@natebosch natebosch changed the title Enable firehouse for package:http to enable automatic publishing Initial publish of ok_http and firehose setup Jul 19, 2024
@natebosch
Copy link
Member

Hmm

Message from server: Package name `ok_http` is too similar to another active package: `okhttp` (https://pub.dev/packages/okhttp).

@jonasfj - is there a workaround?

@natebosch
Copy link
Member

Pub deployment went through and I was able to publish.
https://pub.dev/packages/ok_http/versions/0.1.0

Next step is to split the workflow file into flutter and non-flutter workflows

natebosch added a commit that referenced this issue Aug 6, 2024
Closes #1259

Add a second copy of the publish workflow with `use-flutter: true`.
Add `ignore-packages` to both workflows to ignore published packages for
the non-relevant SDK.
@natebosch natebosch linked a pull request Aug 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants