Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support adding comments #71

Open
xsahil03x opened this issue Apr 10, 2024 · 1 comment
Open

feature: support adding comments #71

xsahil03x opened this issue Apr 10, 2024 · 1 comment
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) type-enhancement A request for a change that isn't a bug

Comments

@xsahil03x
Copy link

xsahil03x commented Apr 10, 2024

Currently there isn't any method to add or update comments in a yaml file.

Usecase: we currently use a script to update dependencies in our flutter projects, We also want to append comments to it showcasing that it's AutoGenerated and should not be modified by hand. invertase/melos#692

A similar approach is being used in Flutter repo: https://github.com/flutter/flutter/blob/master/packages/flutter/pubspec.yaml#L33-L49

@sigurdm sigurdm added contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) type-enhancement A request for a change that isn't a bug labels May 2, 2024
@jonasfj
Copy link
Member

jonasfj commented May 6, 2024

I think this could cool, maybe just adding comment at the end of line for keys in a map.

But even this is really hard to express.

What happens if a map is flow mode, instead of blockmode? What if there is already a comment there?


To be clear, if someone wants to work on this, I'd be happy to help with reviews.
I think should could be a really cool feature to have.

But it's also a feature that would need limitations and LOTS of tests 🤣

@kekavc24 kekavc24 mentioned this issue Jul 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants