-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks fail with duckplyr #720
Comments
hi @krlmlr I've reduced the error to this simple reprex: your branch: dplyr::tibble(
x = c(2000L, NA_integer_),
y = c(1000L, 1000L)
) |>
dplyr::mutate(new_col = dplyr::if_else(
.data$x <= .data$y,
.data$x,
.data$y
))
#> # A tibble: 2 × 3
#> x y new_col
#> <int> <int> <int>
#> 1 2000 1000 1000
#> 2 NA 1000 1000 Created on 2024-10-29 with reprex v2.0.2 dplyr current behavior: dplyr::tibble(
x = c(2000L, NA_integer_),
y = c(1000L, 1000L)
) |>
dplyr::mutate(new_col = dplyr::if_else(
.data$x <= .data$y,
.data$x,
.data$y
))
#> # A tibble: 2 × 3
#> x y new_col
#> <int> <int> <int>
#> 1 2000 1000 1000
#> 2 NA 1000 NA Created on 2024-10-29 with reprex v2.1.1 |
Brilliant, that's exactly the kind of reprex I'm looking for. Thank you! |
Will be fixed soon in duckplyr, I no longer see issues with PatientProfiles in the modified dplyr package. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The duckplyr package is aimed to be a drop-in replacement for dplyr, with full behavior compatibility. To assert that, I'm running checks with a rigged version of dplyr. This package fails its checks in this scenario.
Details: https://github.com/krlmlr/dplyr/blob/f-revdep-duckplyr/revdep/problems.md .
Learn more about duckplyr: https://duckplyr.tidyverse.org/ .
From the error message, I can't tell immediately what the cause of the failure is. I'd appreciate your help: can you please help digest a reproducible example that shows how duckplyr is behaving differently from dplyr in your use case?
The modified dplyr version can be installed with any of:
Thanks a lot for your help! Please let me know if you have any questions.
Tracker: tidyverse/duckplyr#297.
The text was updated successfully, but these errors were encountered: