Skip to content
This repository has been archived by the owner on Mar 28, 2022. It is now read-only.

Make width & height typedefs optional #1

Open
gigerbytes opened this issue May 16, 2020 · 5 comments · May be fixed by #6
Open

Make width & height typedefs optional #1

gigerbytes opened this issue May 16, 2020 · 5 comments · May be fixed by #6
Assignees
@gigerbytes
Labels
bug Something isn't working

Comments

@gigerbytes
Copy link
Member

The library currently requires users to specify width& height parameters, so it is impossible to leave them empty and have the camera take the full width of the screen (default behaviour without width & height specified).

Fix: Make these optional, and allow string input for specifying percentages.
@stamahto
Copy link

stamahto commented Jun 4, 2020

Yep, I would appreciate too.

@samuelpucat
Copy link

setting width="100%" worked for me

@Tohaker
Copy link

Tohaker commented Jul 10, 2020

setting width="100%" worked for me

How? The type is set to number only - it would never compile with a string

@gigerbytes gigerbytes self-assigned this Aug 4, 2020
gigerbytes added a commit that referenced this issue Aug 4, 2020
@gigerbytes
Typsecript bugfix #1
6d0e894
@gigerbytes gigerbytes added the bug Something isn't working label Aug 4, 2020
@gigerbytes
Copy link
Member Author

@phillytan could you test thx

@gigerbytes gigerbytes linked a pull request Aug 4, 2020 that will close this issue
Open
@KayBeSee
Copy link

I would appreciate this as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gigerbytes gigerbytes

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typsecript bugfix #1 dashboardphilippines/react-webcam-barcode-scanner
5 participants
@KayBeSee @gigerbytes @samuelpucat @Tohaker @stamahto