Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: instant send doesn't work in browser #53

Open
coolaj86 opened this issue Jan 4, 2023 · 1 comment
Open

bug: instant send doesn't work in browser #53

coolaj86 opened this issue Jan 4, 2023 · 1 comment
Assignees

Comments

@coolaj86
Copy link
Member

coolaj86 commented Jan 4, 2023

Browser shim for request should properly encode json and forms.

What was the specific method, url, and error @jojobyte?

@coolaj86 coolaj86 self-assigned this Jan 4, 2023
@jojobyte
Copy link
Contributor

jojobyte commented Jan 4, 2023

This code appears to be broken: https://github.com/dashhive/dashsight.js/blob/main/dashsight.js#L144-L154

And the description here https://github.com/therootcompany/request.js#requestoptions-callback may need to be updated for json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants