Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is currently failing #613

Closed
guillaumeeb opened this issue Aug 4, 2023 · 5 comments
Closed

CI is currently failing #613

guillaumeeb opened this issue Aug 4, 2023 · 5 comments

Comments

@guillaumeeb
Copy link
Member

Two things to look at:

@jrueb
Copy link
Contributor

jrueb commented Aug 4, 2023

One thing I noticed is that this looks really outdated

- repo: https://gitlab.com/pycqa/flake8

flake8 moved to github years ago, see https://flake8.pycqa.org/en/latest/release-notes/4.0.0.html "Migrate from GitLab to GitHub"

@kaelancotter
Copy link
Contributor

Are you looking for help with this?

@guillaumeeb
Copy link
Member Author

Definitely!

@kaelancotter
Copy link
Contributor

Created PR 636 to resolve CI failures.
Unfortunately CI fails in the PR since the updated images aren't pushed from the build step if its a PR - so CI action is still using the old docker images.
LMK if there's another direction I should take this to deal with the docker image catch-22

Specific to SGE tests - adding the --full-trace flag got rid of the seg fault, but I don't have a good root cause analysis.

This PR also doesn't address CI for documentation.

guillaumeeb pushed a commit that referenced this issue Mar 22, 2024
* update conda env setup

* init conda after env create

* switch to conda run, add full-trace flag to sge pytests
@jacobtomlinson
Copy link
Member

CI is in a much better place. #653 is still outstanding but I think we can close this issue in favour of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants