Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of Databricks Apps which manages a job created by the same bundle #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andrewnester
Copy link
Contributor

@andrewnester andrewnester commented Nov 28, 2024

Example of Databricks Apps which manages a job created by the same bundle

@andrewnester andrewnester requested a review from pietern November 28, 2024 13:33
Copy link
Contributor

@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this example! Minor comments.

knowledge_base/databricks_app/resources/app_job.job.yml Outdated Show resolved Hide resolved
spec:
client: "1"
dependencies:
- cowsay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, but something to keep in mind: cowsay has a copyleft license

valueFrom: "app-job"

# The resources which this app have an access to.
resources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for this PR: we really need to find a different name for this property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants