Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming: Make "component" rather than "bean", and "job part" instead of "bean job" #60

Open
kaspersorensen opened this issue Dec 4, 2014 · 0 comments

Comments

@kaspersorensen
Copy link
Member

We have some symptoms of changing naming styles in AnalyzerBeans. Of course this persists mostly due to concerns about compatibility. But it's becoming a good time to revisit that and allow breaking changes. I'm saying this since anyways a DataCleaner 4.0 release is pending so big changes may come there...

I suggest therefore to change the following:

  • Deprecate annotations @TransformerBean, @FilterBean and @AnalyzerBean. Instead introduce a single annotation, Component
  • Remove the generic argument of Transformer. A transformer should always return an object-array and instead the getOutputColumns() should be able to define the expected types.
  • Rename the "bean builder" classes into "component builder" classes.
  • Rename the TransformerJob, FilterJob and AnalyzerJob interfaces into TransformerJobPart, FilterJobPart etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant