-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the graphql-transport-ws subprotocol #71
Comments
It looks like it already support the graphql-ws library: It is just expecting the wrong protocol name |
I'm facing this particular issue too :( |
I would love to see this as well, especially since Unfortunately it's not just a matter of changing the protocol name.
|
From the Apollo page: Note: Confusingly, the subscriptions-transport-ws library calls its WebSocket subprotocol graphql-ws, and the graphql-ws library calls its subprotocol graphql-transport-ws! In this article, we refer to the two libraries (subscriptions-transport-ws and graphql-ws), not the two subprotocols. So by expecting the graphql-ws subprotocol, this means that this library is supporting the deprecated subscriptions-transport-ws library and no the graphql-ws library ! |
added a pull request #97 I hope it will be accepted soon it fixes this sorry for the wrong naming |
@prokher Any update on this issue considering the recent (and very much welcomed ❤️ ) upgrade of DjangoChannelsGraphqlWs? The latest versions of Django, Graphene and Channels are now supported, but supporting the latest websocket-based protocol is just as important.
As stated in my previous comment, the referred subscription-transport-ws library has been unmaintained since 2018 and Apollo has long switched to the newer protocol. |
@fdev, the protocol upgrade it is one of our next tasks, so stay tuned 😉 |
I have the same issue. I hope it's fixed soon so we can use it. |
I also have the same problem. What is your prediction about the time of release of the new version? |
The Library currently supports the
subscriptions-transport-ws
subprotocol, but this library is no longer being maintained and recommends developers migrate to the graphql-ws library instead, which uses thegraphql-transport-ws
subprotocol, making it incompatible with this library.I am happy to research how to implement this protocol with this library, I just wanted to open this issue to open a dialogue on other people's thoughts.
The text was updated successfully, but these errors were encountered: