Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in EagerVis #521

Open
oltionchampari opened this issue Sep 13, 2024 · 1 comment
Open

Infinite loop in EagerVis #521

oltionchampari opened this issue Sep 13, 2024 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@oltionchampari
Copy link
Contributor

oltionchampari commented Sep 13, 2024

Environment

  • Release number or git hash: develop
  • Browser: chrome
  • Deployed / Local: both

Steps to reproduce the bug

Observed Behavior

After PR got merged we get into an infinite loop in Ordino the setExtenralConfig is called continuously with the same props
I was able to fix this by having a local useState https://github.com/datavisyn/reprovisyn/blob/6f31c51f354238ac95da40a54c9004d3d29f8d76/src/views/VisVisynView.tsx#L80
but that is not correct and causes another bug

Expected Behavior

Should not cause an infinite loop

Thanks for taking the time to fill out this bug report 🤗
Make sure there aren't any open/closed issues for this topic 😃

@oltionchampari oltionchampari added the type: bug Something isn't working label Sep 13, 2024
@puehringer
Copy link
Contributor

What exactly is causing the infinite loop? Can you add an example/branch in visyn_core that reproduces it in the visyn_core demo app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants