Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe use of Field Dimensions #68

Open
mroethlin opened this issue Jan 12, 2021 · 0 comments
Open

Unsafe use of Field Dimensions #68

mroethlin opened this issue Jan 12, 2021 · 0 comments
Labels
med-effort Requires medium effort/time med-prio Medium priority issue/task tech-debt Technical debt that is overdue

Comments

@mroethlin
Copy link
Contributor

The function get_field_dimension in semantics.py is

  • a misnomer, it returns, in fact, the horizontal dimensions
  • possibly used in unsafe manners (i.e. not guarded against vertical fields)
@mroethlin mroethlin added bug Something isn't working tech debt/maintenance labels Jan 12, 2021
@BenWeber42 BenWeber42 added tech-debt Technical debt that is overdue med-effort Requires medium effort/time med-prio Medium priority issue/task and removed tech debt/maintenance bug Something isn't working labels Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
med-effort Requires medium effort/time med-prio Medium priority issue/task tech-debt Technical debt that is overdue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenWeber42 @mroethlin