Skip to content
This repository has been archived by the owner on Jul 31, 2021. It is now read-only.

Request: Yosemite compatible #1

Open
ellaosx2007 opened this issue Dec 19, 2018 · 10 comments
Open

Request: Yosemite compatible #1

ellaosx2007 opened this issue Dec 19, 2018 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@ellaosx2007
Copy link

ellaosx2007 commented Dec 19, 2018

Hi.
Thanks for this :)
Can you make it at least Yosemite compatible? Or bettet yet Mavericks?

@dbolger
Copy link
Owner

dbolger commented Dec 25, 2018

Definitely! I just got around to seeing this.

Are there any issues when trying to open the application on either of these operating systems?

@dbolger dbolger self-assigned this Dec 25, 2018
@dbolger dbolger added enhancement New feature or request good first issue Good for newcomers labels Dec 25, 2018
@dbolger dbolger assigned dbolger and unassigned dbolger Dec 25, 2018
@ellaosx2007
Copy link
Author

ellaosx2007 commented Dec 26, 2018

Hi
This is what im getting using previous OS than 10.13
dw140

@dbolger
Copy link
Owner

dbolger commented Dec 26, 2018

Looking now, Mavericks support will be an involving task but I should be able to manage adding Yosemite support fairly quickly. I should have an update pushed within an hour.

@dbolger
Copy link
Owner

dbolger commented Dec 26, 2018

Keeping this issue open until Mavericks support is added

  • 40681a5 adds support for 10.10.x-10.12.6, versions previously not supported.
    Download link for macOS 10.10+.

UPDATE 12/26/18 -
I'm going to be implementing some features that require a newer version of macOS to be used. This .app should work, however, from now on, you can find the latest features listed on the Readme on the Releases page. Hopefully, I can get around to adding support for these new features later on but right now I'm just hoping to support them in the latest version of macOS itself.

@ellaosx2007
Copy link
Author

Yosemite+ now works. which version of xcode are you using?

@dbolger
Copy link
Owner

dbolger commented Dec 26, 2018

I’m using Xcode 10, a bunch of things changed after 10.9 though - reason why support for that might take longer.

@ellaosx2007
Copy link
Author

tried using xcode 9.4.1 but got 2 errors:
dw140_compile_error

Replacing the 2 NSImage.Name(rawValue: instances with NSImage(named: fixed it.
Probably due to 9.4.1. i dont have xcode 10 yet. just FYI :)

No worries with 10.9 support :)
Thanks!

@ellaosx2007
Copy link
Author

ellaosx2007 commented Dec 26, 2018

OH nooooo! Did i just close this topic?

@ellaosx2007 ellaosx2007 reopened this Dec 26, 2018
@dbolger
Copy link
Owner

dbolger commented Dec 26, 2018

I don’t understand why you’re trying to compile it specifically with Xcode 9. The .app file I provided above should be sufficient. If you have any other feature requests you can just drop them here in the comments or create a new issue.

@ellaosx2007
Copy link
Author

ellaosx2007 commented Dec 27, 2018

I was just trying to compile it myself to test 10.9, but didnt work :D
Your current build works w/o issues. I will post again once i can think of a new feature or found a bug.

@dbolger dbolger removed the good first issue Good for newcomers label Jan 3, 2019
@dbolger dbolger pinned this issue Jan 3, 2019
@dbolger dbolger unpinned this issue Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants