-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh: move train and eval scripts to methods, pip package #299
Comments
Hmm, the issue is there's a lot of global set up stuff that goes on since I never intended you to be able to call As for running the model externally (outside of The eval pipeline doesn't have a lot of global side effects though (only 2 changes required according to the last comment in that issue), so that should be easier. Onto the TODO list it goes. |
applied in PR #304
yes, this is an important part of what I meant by "having a (big) framework API" #300 |
The (possible) mmdetection provides an API for eval, visualization, ... Not sure if that's enough or if this code would support it, but it could be a step to standardization.
and you're right, calling |
@dbolya do you have some WIP on this? If not, I'd start atleast a small bits of this. We need yolact to be used as a pip package and from another code, ideally. |
@breznak It would be a great help if you could get started on this, since I'm swamped with other projects. |
I'll be happy to 👍 If you have time, please give a high-level review if it's going in the direction you approve of, so I don't develop too deep into something undesired. |
@breznak please do let us knw once its done this work would be really good , can you share your mail id so as to communicate wiht you and support you if required |
Currently
train.py
andeval.py
are implemented as scripts. This causes some problems when interfacing YOLACT from python.I'd like to propose changing from separate script files (the scripts can still exist for convenience) to more OOP approach and having
train()
,eval()
as part of the Yolact class.This would allow us to make a
pip
package for this repo for much easier integration in other projects (currently I suffer with git submodules)The text was updated successfully, but these errors were encountered: