Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Support complex Array data types for macro get_columns_in_relation #310

Open
2 tasks done
jdistler opened this issue Sep 18, 2024 · 3 comments · May be fixed by #311
Open
2 tasks done

[Bug] Support complex Array data types for macro get_columns_in_relation #310

jdistler opened this issue Sep 18, 2024 · 3 comments · May be fixed by #311
Labels
bug Something isn't working

Comments

@jdistler
Copy link

jdistler commented Sep 18, 2024 •
edited
Loading

Is this a new bug?

  • I believe this is a new bug
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

If a given column is a complex ARRAY type such as ARRAY(VARCHAR(16777216)), the macro get_columns_in_relation raises an error.

Expected Behavior

We can better handle this case to not raise an error.

Steps To Reproduce

Do a dbt run on a model which calls adapter.get_columns_in_relation() on a table with a column of type ARRAY(VARCHAR(16777216)).

Relevant log output

Could not interpret data_type "ARRAY(VARCHAR(16777216))": could not convert "VARCHAR(16777216" to an integer

Environment

- OS:
- Python: 3.11.4
- dbt-adapters: 1.6.1

Additional Context

Relevant code that can more gracefully handle this case -

https://github.com/dbt-labs/dbt-adapters/blob/v1.6.1/dbt/adapters/base/column.py#L142-L146
@jdistler jdistler added bug Something isn't working triage labels Sep 18, 2024
@jdistler jdistler linked a pull request Sep 18, 2024 that will close this issue
Draft
4 tasks
@jdistler
Copy link
Author

Note the similarities with this other issue, in general this area of the logic is very brittle and should be made more flexible -

dbt-labs/dbt-snowflake#1098

@amychen1776
Copy link

amychen1776 commented Sep 26, 2024 •
edited
Loading

Hello @jdistler - are you coming across this on Snowflake?

@jamesmorris23
Copy link

jamesmorris23 commented Oct 15, 2024 •
edited
Loading

Hi all – 

I'm running into this currently while attempting to build an incremental model with vector embeddings for use in a simple RAG pipeline in Snowflake. Is there any update on prioritization of a fix here or workaround in the short term. It's untenable and wasteful to not run models like these in an incremental fashion.

Thanks in advance! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better handle nested Array types jdistler/dbt-adapters
3 participants
@jdistler @jamesmorris23 @amychen1776