Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design addition: credit and contact line #106

Open
WABA-Comms opened this issue Sep 2, 2016 · 5 comments
Open

Design addition: credit and contact line #106

WABA-Comms opened this issue Sep 2, 2016 · 5 comments
Assignees

Comments

@WABA-Comms
Copy link
Collaborator

WABA-Comms commented Sep 2, 2016

PROPS!

Trusting your design eye and design decisions for a sleek, simple, consistent look. Please add, "This map was built by incredible volunteers from DCFemTech (link) and Code For DC (link). The bike data (link to data matrix) was pulled from the respective DOTs on September 1st, 2016. Send bike infrastructure questions to [email protected]. ”

Color: Your call
Size: You do you
Position: the best place

@hareno44
Copy link
Collaborator

hareno44 commented Sep 7, 2016

I need a link to the data matrix, but otherwise the task is completed.

@alulsh
Copy link
Member

alulsh commented Sep 7, 2016

@hareno44 - can you add a screenshot of the credit & contact line from your WIP branch to this GitHub issue? This will help us review your work.

@hareno44
Copy link
Collaborator

hareno44 commented Sep 7, 2016

image

<div id="description>
<!-- map description code here -->

<p>This map was built by incredible volunteers from
<a href="https://dcfemtech.github.io/">DCFemTech</a> and
<a href= "http://codefordc.org/">Code For DC</a>.The bike data (link to data matrix) was <br>pulled from the respective DOTs on September 1st, 2016.Send bike infrastructure questions to [email protected].</p>
</div>

@alulsh
Copy link
Member

alulsh commented Sep 7, 2016

@hareno44 - looks like you copied and pasted code from the branch instead of linking to the branch. For example, if I paste https://github.com/dcfemtech/hackforgood-waba-map/pull/127 into a GitHub issue comment it will turn into #127, a smart reference link to your pull request.

The menu + text in the header look a lot bigger in this screenshot than in other ones - did you zoom in in your browser or did you change the CSS of the text so it was larger?

@hareno44
Copy link
Collaborator

hareno44 commented Sep 7, 2016

@alulsh Thanks for the tip! Oh, I just zoomed in on the one part, though afterwards I think I'd just keep it to the regular, full page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants