From d754535a4a04a86d0da710828cb1487d52958eea Mon Sep 17 00:00:00 2001 From: Daniel Sjoberg Date: Wed, 18 Sep 2024 09:44:28 -0700 Subject: [PATCH] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2fa240b1e5..3a2b2e34a1 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,5 @@ **What changes are proposed in this pull request?** - +<< Insert text here that can be directly copied into NEWS.md by your reviewer. >> **If there is an GitHub issue associated with this pull request, please provide link.** @@ -8,12 +8,12 @@ Reviewer Checklist (if item does not apply, mark is as complete) -- [ ] Ensure all package dependencies are installed: `renv::install()` -- [ ] PR branch has pulled the most recent updates from master branch: `usethis::pr_merge_main()` +- [ ] PR branch has pulled the most recent updates from main branch. - [ ] If a bug was fixed, a unit test was added. - [ ] Run `pkgdown::build_site()`. Check the R console for errors, and review the rendered website. - [ ] Code coverage is suitable for any new functions/features: `devtools::test_coverage()` - [ ] `usethis::use_spell_check()` runs with no spelling errors in documentation +- [ ] **All** GitHub Action workflows pass with a :white_check_mark: When the branch is ready to be merged into master: - [ ] Update `NEWS.md` with the changes from this pull request under the heading "`# gtsummary (development version)`". If there is an issue associated with the pull request, reference it in parentheses at the end update (see `NEWS.md` for examples).