Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbl_hierarchical() enhancements #2021

Open
4 of 13 tasks
edelarua opened this issue Oct 3, 2024 · 0 comments
Open
4 of 13 tasks

tbl_hierarchical() enhancements #2021

edelarua opened this issue Oct 3, 2024 · 0 comments
Labels
enhancement 🌟 New feature or request High Priority High priority issue
Milestone

Comments

@edelarua
Copy link
Collaborator

edelarua commented Oct 3, 2024

Enhance tbl_hierarchical() with the following features:

  • Add digits argument to tbl_hierarchical() #2032
  • Add control for denominator used after row splits
  • Remove code that identifies type since it’s not used - only categorical variables supported.
  • Add checks to verify all of data[variables] are categorical variables.
  • Perform thorough review of the tbl_hierarchical() internals and utilize the existing helpers in the pkg as needed. @ddsjoberg
  • @edelarua to investigate other nested data table structures and we will discuss which to support.
  • Investigate how we could/should use over_variables when it's not just a single row, e.g. over AESEV or Grade.
  • Update tbl_ard_hierarchical() with structural checks of the ARD inputs
  • Should cards::ard_hierarchical() and the count function optionally include the attributes from the data frame so we can use them in the header? I wonder if it's necessary? The ARD-first approach for these tables are not really general, so the utility of this function is pretty limited. If I needed an ARD, it may be best to just create the table, then grab the ARD from the table object..... 🤔
  • All sorts of updates will be needed for tbl_ard_hierarchical()
  • Investigate whether we can implement the bridge function without modifying the primary brdg_summary() function Separate internal hierarchy processing from summary functions #2033
    • Same for .add_gts_column_to_cards_summary()
    • The reason for these is that the primary function is used all over the place, so best to keep it as clean and simple as possible.
@edelarua edelarua added the enhancement 🌟 New feature or request label Oct 3, 2024
@ddsjoberg ddsjoberg added this to the v2.1.0 milestone Oct 3, 2024
@ddsjoberg ddsjoberg added the High Priority High priority issue label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request High Priority High priority issue
Projects
None yet
Development

No branches or pull requests

2 participants