Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localhost is not blacklisted for webhooks & it follows redirects #624

Open
vikstrom opened this issue Feb 26, 2024 · 1 comment
Open

Localhost is not blacklisted for webhooks & it follows redirects #624

vikstrom opened this issue Feb 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working high-priority

Comments

@vikstrom
Copy link

vikstrom commented Feb 26, 2024

There seems to be no issue creating a webhook with a payloadUrl pointing to localhost.

I'd recommend to blacklist localhost and 127.0.1 since there are no use-case for creating a webhook to localhost and it only introduces possible attack vectors.

I've verified that it does indeed try to connect to localhost by using netcat to listen for connections directly in the container.

Also; the webhook follows redirects. I was able to redirect the webhook from a POST request to a GET request. But I was not able to exploit it any further.

@vikstrom vikstrom changed the title Localhost is not blacklisted for webhooks Localhost is not blacklisted for webhooks & it follows redirects Feb 26, 2024
@georgepadayatti georgepadayatti added enhancement New feature or request bug Something isn't working high-priority and removed enhancement New feature or request labels Feb 26, 2024
@vikstrom
Copy link
Author

This combined with #623 is a particularly troublesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

No branches or pull requests

3 participants