Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Embed Target Example for Credential Manifest is wrong #154

Open
decentralgabe opened this issue May 17, 2023 · 1 comment · May be fixed by #159
Open

The Embed Target Example for Credential Manifest is wrong #154

decentralgabe opened this issue May 17, 2023 · 1 comment · May be fixed by #159

Comments

@decentralgabe
Copy link
Member

https://identity.foundation/credential-manifest/#credential-manifest-2

It shows a credential application

@toteto toteto linked a pull request Oct 26, 2023 that will close this issue
@bnonni
Copy link

bnonni commented Aug 29, 2024

@decentralgabe I came to this repo to submit this same issue. Not only am I glad to see that someone has already submitted it, but I'm even happier to see there's a PR. I'm also glad because I spent some much time reviewing and re-reviewing this spec document only to end up confused. I did finally figured it out, and I came to the conclusion that the docs were wrong. Thankfully, I was able to use the rest of the document to put together a valid credential-manifest, but it would be ideal to help others avoid this hassle in the future.

Thank you @toteto for the PR. Can we get #159 merged in? What is the process for merging these PRs? Can I help in any way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants