Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lesson03: binary confusion matrix true/false order #51

Open
elcorto opened this issue Mar 23, 2022 · 2 comments
Open

lesson03: binary confusion matrix true/false order #51

elcorto opened this issue Mar 23, 2022 · 2 comments

Comments

@elcorto
Copy link
Contributor

elcorto commented Mar 23, 2022

In addition to deeplearning540/lesson03#1, sklearn also uses y_{true,pred} = [False, True] such that TN = C[0,0] and so forth, as opposed to [True,False] in wikipedia.

https://scikit-learn.org/stable/modules/generated/sklearn.metrics.confusion_matrix.html

@psteinb
Copy link
Collaborator

psteinb commented Mar 23, 2022

Sounds like we simply should create our own table. :-) That is long overdue.

@PrometheusPi
Copy link

Could it be that the labels used in the lecture video for ConfusionMatrixDisplay were inverted?

If tp = cm[1,1] that the lower right entry should be the Adele penguin. But with display_labels=["Adele", "not Adele"] it looks like the upper left (true negative) is the Adele penguin.

Wouldn't display_labels=["not Adele", "Adele"] be the correct labeling?

@elcorto elcorto transferred this issue from deeplearning540/lesson03 Mar 23, 2022
@elcorto elcorto changed the title binary confusion matrix true/false order lesson03: binary confusion matrix true/false order Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants