Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove s3_cli module from test_utils #1558

Open
rtyler opened this issue Jul 24, 2023 · 1 comment · May be fixed by #1570
Open

Remove s3_cli module from test_utils #1558

rtyler opened this issue Jul 24, 2023 · 1 comment · May be fixed by #1570
Labels
binding/rust Issues for the Rust crate bug Something isn't working good first issue Good for newcomers

Comments

@rtyler
Copy link
Member

rtyler commented Jul 24, 2023

In rust/src/test_utils.rs we have some shell invocations of the AWS cli which aren't necessary (IMHO) because we can do all of these operations directly from Rusoto without adding the system dependency.
@rtyler rtyler added bug Something isn't working binding/rust Issues for the Rust crate good first issue Good for newcomers labels Jul 24, 2023
@marijncv marijncv linked a pull request Jul 28, 2023 that will close this issue
Open
@marijncv
Copy link
Contributor

marijncv commented Jul 28, 2023 •
edited
Loading

Hey @rtyler, I started taking a look at this issue and I'm wondering if it's going in the right direction with my draft PR #1570.

For now just creating the bucket with rusoto_s3 using their async API, but it required me to make a lot more functions async as well. Is that an issue? Or is there perhaps a better way of doing it? Curious for your feedback!

Edit: 0f015aa uses futures::executor::block_on() to deal with the async API of rusoto_s3 as an alternative to the approach of making more functions asyc, but it requires the tests that use it to have the #[tokio::test(flavor = "multi_thread")] macro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove s3_cli from test_utils.rs marijncv/delta-rs
2 participants
@rtyler @marijncv