Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put avro support behind an optional feature flag #163

Open
rtyler opened this issue Jan 7, 2024 · 1 comment
Open

Put avro support behind an optional feature flag #163

rtyler opened this issue Jan 7, 2024 · 1 comment
Assignees
@rtyler
Labels
enhancement New feature or request
Milestone
kafka-delta-inges...

Comments

@rtyler
Copy link
Member

rtyler commented Jan 7, 2024

It will speed up local development a bit if the avro dependencies can be turned off. We're linking well over 400 crates right now by default 🤯
@rtyler rtyler added the enhancement New feature or request label Jan 7, 2024
rtyler added a commit that referenced this issue Jan 8, 2024
@rtyler
Put avro dependenciies behind the avro feature flag
48e584a 
Turning avro off drops about 50 crates from the default build, so useful
for development, but the code would need to be cleaned up to remove this
from the default features list

See #163
rtyler added a commit that referenced this issue Jan 8, 2024
@rtyler
Remove avro from the default features and feature gate its cpde
437d074 
This change is a little wrapped up in the introduction of
DeserializedMessage but the trade-off for development targeting S3 is
that I am linking 382 crates every cycle as opposed to 451.

Fixes #163
rtyler added a commit that referenced this issue Jan 8, 2024
@rtyler
Put avro dependenciies behind the avro feature flag
ce8d436 
Turning avro off drops about 50 crates from the default build, so useful
for development, but the code would need to be cleaned up to remove this
from the default features list

See #163
rtyler added a commit that referenced this issue Jan 8, 2024
@rtyler
Remove avro from the default features and feature gate its cpde
1987042 
This change is a little wrapped up in the introduction of
DeserializedMessage but the trade-off for development targeting S3 is
that I am linking 382 crates every cycle as opposed to 451.

Fixes #163
@rtyler
Copy link
Member Author

rtyler commented Jan 9, 2024

This is actually addressed as part of #164 because I was trying to limit my build/link times 😄

@rtyler rtyler self-assigned this Jan 9, 2024
@rtyler rtyler added this to the kafka-delta-ingest 0.2 release milestone Jan 9, 2024
rtyler added a commit that referenced this issue Jan 9, 2024
@rtyler
Put avro dependenciies behind the avro feature flag
f8eb561 
Turning avro off drops about 50 crates from the default build, so useful
for development, but the code would need to be cleaned up to remove this
from the default features list

See #163
rtyler added a commit that referenced this issue Jan 9, 2024
@rtyler
Remove avro from the default features and feature gate its cpde
72aff33 
This change is a little wrapped up in the introduction of
DeserializedMessage but the trade-off for development targeting S3 is
that I am linking 382 crates every cycle as opposed to 451.

Fixes #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtyler rtyler

Labels
enhancement New feature or request
Projects
None yet
Milestone
kafka-delta-ingest 0.2 release
Development

No branches or pull requests
1 participant
@rtyler