Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more detailed connection parameters #22

Open
quapka opened this issue Mar 4, 2018 · 1 comment
Open

Add support for more detailed connection parameters #22

quapka opened this issue Mar 4, 2018 · 1 comment

Comments

@quapka
Copy link
Contributor

quapka commented Mar 4, 2018

On the front page you mention:

You can also specify additional OPTIONS attribute as described in http://django-mssql.readthedocs.io/en/latest/settings.html#options

The link talks about extra_params. But I don't see it being passed to pytds.connect(). The part of the code responsible for creating the connection dict either hardcodes some values or checks _SUPPORTED_OPTIONS, which contains only failover_partner (that is already retrieved from the options few lines prior to checking _SUPPORTED_OPTIONS).

In my case I'm missing the ability to set timeout and login_timeout (which should as easy as just passing them to connect - e.g. through updating _SUPPORTED_OPTIONS). I don't know about an easy way of adding extra_params support, since I don't see that one being accepted by the connect function.

@quapka
Copy link
Contributor Author

quapka commented Mar 7, 2018

After the merge of #23 all of the kwargs from pytds.connect() should be supported.

extra_params is not one of those, so it's still not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant