Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

[Review Page] Resolve circle dependency build warnings #601

Open
3 tasks
bjmccotter7192 opened this issue Aug 30, 2022 · 0 comments
Open
3 tasks

[Review Page] Resolve circle dependency build warnings #601

bjmccotter7192 opened this issue Aug 30, 2022 · 0 comments
Labels
VA Forms System Core For Forms Library Team work on the new VA Forms System Core

Comments

@bjmccotter7192
Copy link
Contributor

bjmccotter7192 commented Aug 30, 2022

Description

After reviewing some of the build logs, there is a few spots in the package that have a possible circular dependency that should be resolved and avoided for the future.

Example Build Log

⠋ Building modules
Circular dependency: src/routing/index.ts -> src/routing/Page.tsx -> src/form-data/PageContext.tsx -> src/routing/index.ts
Circular dependency: src/form-builder/index.ts -> src/form-builder/TextField.tsx -> src/form-data/index.tsx -> src/form-data/ReviewPage.tsx -> src/form-builder/index.ts
Circular dependency: src/routing/index.ts -> src/routing/Page.tsx -> src/form-data/PageContext.tsx -> src/routing/index.ts
Circular dependency: src/form-builder/index.ts -> src/form-builder/TextField.tsx -> src/form-data/index.tsx -> src/form-data/ReviewPage.tsx -> src/form-builder/index.ts
Circular dependency: src/routing/index.ts -> src/routing/Page.tsx -> src/form-data/PageContext.tsx -> src/routing/index.ts

Considerations

  • Based on the way we are building the ReviewPage component this could be tricky to untangle.

Tasks

  • Refactor ReviewPage and PageContent to not circle back to the route

Acceptance Criteria

  • Tasks have been completed
  • PR has been merged into main
@bjmccotter7192 bjmccotter7192 added the VA Forms System Core For Forms Library Team work on the new VA Forms System Core label Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
VA Forms System Core For Forms Library Team work on the new VA Forms System Core
Projects
None yet
Development

No branches or pull requests

1 participant