Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow Redis RPC's client to add messages to streams that doesn't exists #148

Open
eyadof opened this issue May 7, 2021 · 0 comments
Open

Don't allow Redis RPC's client to add messages to streams that doesn't exists #148

eyadof opened this issue May 7, 2021 · 0 comments

Comments

@eyadof
Copy link
Contributor

eyadof commented May 7, 2021

We have at least two issues in the current RPC handling:

  • A client sending messages to a service that doesn't exist.
  • A client sending messages to a method that isn't implemented.

Although the client (per spec) will eventually timeout and the correctness of the application will be maintained, this will leave garbage in Redis.

We should implement a way to prevent the RPC client from adding messages in these two cases.

  • In Redis 6.2+ xadd has the NOMKSTREAM option.
  • for Redis 5 and less the key idea is to combine one exists call then monitor the keyspace for changes on the key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyadof