Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency between assignments and the plots #238

Open
Srheft opened this issue Nov 14, 2019 · 3 comments
Open

inconsistency between assignments and the plots #238

Srheft opened this issue Nov 14, 2019 · 3 comments

Comments

@Srheft
Copy link
Contributor

Srheft commented Nov 14, 2019

@tskisner @sbailey

This is the first time I'm seeing this:

fiberassign output (intermediate, merged and qa.json) don't show any unassigned fiber while the plot shows unassigned fibers with this warning while creating the plot:

WARNING: Positioner at location 7243 cannot move to target 576471653823808043 at (x, y) = (-256.77994301496796, 146.77159324479825). This should have been dected during assignment!

image

The assignment files show that fiber 7243 is assigned to the same TARGETID as reported in the warning (576471653823808043) but the coordinates for the target in the warning is incorrect. The target is a sky supplement location at TARGET_RA=21.88100106, TARGET_DEC=31.15930374.

the inputs and running commands are here.

any thought?

@tskisner
Copy link
Member

Will try to investigate soon.

@tskisner
Copy link
Member

Note that this "warning" has been promoted to an exception, and I have not seen it in my recent tests. I'll leave this open for now, but post any updates if you see it happen again.

@dstndstn
Copy link
Contributor

dstndstn commented May 5, 2021

This may have been fixed as part of #340.

Another possibility (that I've run into!) is that if the focal-plane model changes between fiberassign and plotting and you don't set --rundate consistently, then the fiber states can change underneath you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants