Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue workspace for reconcile if workspace health check encounters an error #1325

Open
AObuchow opened this issue Oct 8, 2024 · 0 comments · May be fixed by #1321
Open

Queue workspace for reconcile if workspace health check encounters an error #1325

AObuchow opened this issue Oct 8, 2024 · 0 comments · May be fixed by #1321
Labels
enhancement New feature or request

Comments

@AObuchow
Copy link
Collaborator

AObuchow commented Oct 8, 2024

Currently, if an error occurs while performing the workspace health check (e.g. a timeout error) then the workspace will no longer be reconciled. In certain environments, there can be a delay during the health check, causing the timeout period to pass, and preventing the workspace from starting up (as it will no longer be reconciled).

Instead, we should requeue workspaces when their health check encounters an error to allow the workspace to start up.
@AObuchow AObuchow added the enhancement New feature or request label Oct 8, 2024
@AObuchow AObuchow linked a pull request Oct 8, 2024 that will close this issue
Open
3 tasks
batleforc added a commit to batleforc/devworkspace-operator that referenced this issue Oct 9, 2024
@batleforc
feat: queue workspace reconcile if workspace health check encounters …
8b49c22 
…an error

fix devfile#1325

Signed-off-by: Max batleforc <[email protected]>
batleforc added a commit to batleforc/devworkspace-operator that referenced this issue Oct 9, 2024
@batleforc
feat: queue workspace reconcile if workspace health check encounters …
7df914e 
…an error

fix devfile#1325

Signed-off-by: Max batleforc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: turn healthCheckHttpClient timeout from 500ms to 3s batleforc/devworkspace-operator
1 participant
@AObuchow