-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ProcessResult: get out and err in order #734
Comments
alfeilex
added a commit
to alfeilex/IDEasy
that referenced
this issue
Nov 19, 2024
…om/alfeilex/IDEasy into devonfw#734-improve-process-result
alfeilex
added a commit
to alfeilex/IDEasy
that referenced
this issue
Nov 19, 2024
alfeilex
added a commit
to alfeilex/IDEasy
that referenced
this issue
Nov 19, 2024
…om/alfeilex/IDEasy into devonfw#734-improve-process-result
alfeilex
added a commit
to alfeilex/IDEasy
that referenced
this issue
Nov 20, 2024
alfeilex
added a commit
to alfeilex/IDEasy
that referenced
this issue
Dec 10, 2024
…rocess-result # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java # cli/src/main/java/com/devonfw/tools/ide/process/ProcessResultImpl.java
alfeilex
added a commit
to alfeilex/IDEasy
that referenced
this issue
Dec 10, 2024
jan-vcapgemini
added a commit
to alfeilex/IDEasy
that referenced
this issue
Dec 12, 2024
alfeilex
added a commit
to alfeilex/IDEasy
that referenced
this issue
Dec 16, 2024
alfeilex
added a commit
to alfeilex/IDEasy
that referenced
this issue
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With #653 we now log the standard output and error messages of a process so the use can see it (e.g. in case of errors) even if it was captured.
However, this now opens a new problem:
We have modelled this as two independent
List
s:IDEasy/cli/src/main/java/com/devonfw/tools/ide/process/ProcessResultImpl.java
Lines 17 to 19 in d146098
With this design it is impossible to print these messages in their original order how it was printed by the actual process.
Let us look at the following example:
This program will let you see this on your console:
However, with IDEasy and DEFAULT_CAPTURE we would get:
The idea and expectation of this story is to change the model (e.g. having a single list of LogEvents) and the way we read the out and err from the thread to preserve the order (as far as possible).
NOTE: With Java Process API it is impossible to create a perfect solution as you can read here.
The text was updated successfully, but these errors were encountered: