Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library does not validate previousProof #33

Open
aljones15 opened this issue Sep 1, 2024 · 1 comment
Open

library does not validate previousProof #33

aljones15 opened this issue Sep 1, 2024 · 1 comment
Assignees

Comments

@aljones15
Copy link
Contributor

{
  "verifiableCredential": {
    "@context": [
      "https://www.w3.org/ns/credentials/v2",
      {
        "@protected": true,
        "DriverLicenseCredential": "urn:example:DriverLicenseCredential",
        "DriverLicense": {
          "@id": "urn:example:DriverLicense",
          "@context": {
            "@protected": true,
            "id": "@id",
            "type": "@type",
            "documentIdentifier": "urn:example:documentIdentifier",
            "dateOfBirth": "urn:example:dateOfBirth",
            "expirationDate": "urn:example:expiration",
            "issuingAuthority": "urn:example:issuingAuthority"
          }
        },
        "driverLicense": {
          "@id": "urn:example:driverLicense",
          "@type": "@id"
        }
      }
    ],
    "id": "urn:uuid:36245ee9-9074-4b05-a777-febff2e69758",
    "type": [
      "VerifiableCredential",
      "DriverLicenseCredential"
    ],
    "credentialSubject": {
      "id": "urn:uuid:1a0e4ef5-091f-4060-842e-18e519ab9440",
      "driverLicense": {
        "type": "DriverLicense",
        "documentIdentifier": "T21387yc328c7y32h23f23",
        "dateOfBirth": "01-01-1990",
        "expirationDate": "01-01-2030",
        "issuingAuthority": "VA"
      }
    },
    "issuer": "did:key:z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT",
    "proof": [
      {
        "id": "urn:uuid:test:first:proof",
        "type": "DataIntegrityProof",
        "created": "2024-09-01T13:51:06Z",
        "verificationMethod": "did:key:z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT#z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT",
        "cryptosuite": "eddsa-rdfc-2022",
        "proofPurpose": "assertionMethod",
        "proofValue": "z3qM4MrKGz5VZPwz8X8s77CSs7q4WrvFHvKGiDbijY6dsBnoBBbDcB21PrpAgSf9mvcLZULzLZyMeKwvJfs1p7Geg"
      },
      {
        "previousProof": "urn:uuid:test:missing:proof",
        "type": "DataIntegrityProof",
        "created": "2024-09-01T13:51:06Z",
        "verificationMethod": "did:key:z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT#z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT",
        "cryptosuite": "eddsa-rdfc-2022",
        "proofPurpose": "assertionMethod",
        "proofValue": "z4yaxcBa8Vqye2frtnU4HgLnzxRJ1FWUZbztqFUfXC1q7Mn7CeRChvXuRNAk4XwLaHXvKeWKJv8UgwMGfgCdhNiHZ"
      }
    ]
  }
}
{
  "result": {
    "verified": true,
    "results": [
      {
        "proof": {
          "@context": [
            "https://www.w3.org/ns/credentials/v2",
            {
              "@protected": true,
              "DriverLicenseCredential": "urn:example:DriverLicenseCredential",
              "DriverLicense": {
                "@id": "urn:example:DriverLicense",
                "@context": {
                  "@protected": true,
                  "id": "@id",
                  "type": "@type",
                  "documentIdentifier": "urn:example:documentIdentifier",
                  "dateOfBirth": "urn:example:dateOfBirth",
                  "expirationDate": "urn:example:expiration",
                  "issuingAuthority": "urn:example:issuingAuthority"
                }
              },
              "driverLicense": {
                "@id": "urn:example:driverLicense",
                "@type": "@id"
              }
            }
          ],
          "id": "urn:uuid:test:first:proof",
          "type": "DataIntegrityProof",
          "created": "2024-09-01T13:51:06Z",
          "verificationMethod": "did:key:z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT#z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT",
          "cryptosuite": "eddsa-rdfc-2022",
          "proofPurpose": "assertionMethod",
          "proofValue": "z3qM4MrKGz5VZPwz8X8s77CSs7q4WrvFHvKGiDbijY6dsBnoBBbDcB21PrpAgSf9mvcLZULzLZyMeKwvJfs1p7Geg"
        },
        "verified": true,
        "verificationMethod": {
          "@context": "https://w3id.org/security/suites/ed25519-2020/v1",
          "id": "did:key:z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT#z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT",
          "type": "Ed25519VerificationKey2020",
          "controller": "did:key:z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT",
          "publicKeyMultibase": "z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT"
        },
        "purposeResult": {
          "valid": true
        }
      },
      {
        "proof": {
          "@context": [
            "https://www.w3.org/ns/credentials/v2",
            {
              "@protected": true,
              "DriverLicenseCredential": "urn:example:DriverLicenseCredential",
              "DriverLicense": {
                "@id": "urn:example:DriverLicense",
                "@context": {
                  "@protected": true,
                  "id": "@id",
                  "type": "@type",
                  "documentIdentifier": "urn:example:documentIdentifier",
                  "dateOfBirth": "urn:example:dateOfBirth",
                  "expirationDate": "urn:example:expiration",
                  "issuingAuthority": "urn:example:issuingAuthority"
                }
              },
              "driverLicense": {
                "@id": "urn:example:driverLicense",
                "@type": "@id"
              }
            }
          ],
          "previousProof": "urn:uuid:test:missing:proof",
          "type": "DataIntegrityProof",
          "created": "2024-09-01T13:51:06Z",
          "verificationMethod": "did:key:z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT#z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT",
          "cryptosuite": "eddsa-rdfc-2022",
          "proofPurpose": "assertionMethod",
          "proofValue": "z4yaxcBa8Vqye2frtnU4HgLnzxRJ1FWUZbztqFUfXC1q7Mn7CeRChvXuRNAk4XwLaHXvKeWKJv8UgwMGfgCdhNiHZ"
        },
        "verified": true,
        "verificationMethod": {
          "@context": "https://w3id.org/security/suites/ed25519-2020/v1",
          "id": "did:key:z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT#z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT",
          "type": "Ed25519VerificationKey2020",
          "controller": "did:key:z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT",
          "publicKeyMultibase": "z6MkwXG2WjeQnNxSoynSGYU8V9j3QzP3JSqhdmkHc6SaVWoT"
        },
        "purposeResult": {
          "valid": true
        }
      }
    ]
  }
}

Add logic to check previousProof

@aljones15 aljones15 self-assigned this Sep 1, 2024
@aljones15
Copy link
Contributor Author

Note this was discussed and requires changes in jsonld-signatures & potentially this library to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant