Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip-compile produces different results on different operating systems #21580

Closed
emord opened this issue Aug 17, 2018 · 1 comment · Fixed by #21667
Closed

pip-compile produces different results on different operating systems #21580

emord opened this issue Aug 17, 2018 · 1 comment · Fixed by #21667
Assignees

Comments

@emord
Copy link
Contributor

emord commented Aug 17, 2018

More context #21559 (comment)

It appears that ipython has different dependencies if you're on a mac vs linux. I think we should default to linux's requirements since that's what our servers run, but as of right now I don't know of a way to enforce that.

This isn't currently breaking anything, but it will probably create some package churn if we start using pip-sync, and could potentially break if a package requires conflicting dependencies on different platforms

fyi: @kaapstorm since you ran into this the other day

@dannyroberts
Copy link
Member

Thanks for raising this; certainly an annoying issue.

I think the best way to ensure that these sorts of platform-dependent discrepancies don't crop up is to run make requirements in travis and assert that there's no resultant git diff. That way if someone with a mac commits something that would have come out differently on linux, that'll become clear right away.

I'd say for ipython in particular, other than minor convenience, I don't think there's a need to have it be in prod-requirements.txt at all; and for dev, it's probably worth including appnope directly with a custom directive telling it to only install on mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants