Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 64bit support #47

Open
Ughuuu opened this issue Apr 16, 2024 · 1 comment · May be fixed by #61
Open

Add 64bit support #47

Ughuuu opened this issue Apr 16, 2024 · 1 comment · May be fixed by #61

Comments

@Ughuuu
Copy link

Ughuuu commented Apr 16, 2024

I integrated rapier and rapier-f64. Then I added salva, but now it doesn't build and salva only works with rapier, not rapier64(eg. features="rapier")
https://github.com/appsinacup/godot-rapier-2d
appsinacup/godot-rapier-physics#61

One solution could be to add same as for rapier, single or double builds, and then for feature add rapier or rapier-f64.

@Ughuuu
Copy link
Author

Ughuuu commented Oct 9, 2024

For this issue one should look at how rapier does it: https://github.com/dimforge/rapier
And basically it needs in salva multiple packages exported, similar to how rapier has. So right now this exports salva2d and salva3d, it would need salva2d-f64 and salva3d-f64. Each of these would be defined in the Cargo.toml file and then there would be a define for the precision:

So in the build directory of salva there would be 2 new folders, salva2d-f64 and salva3d-f64. Then in github workflows there needs to be automatic building (and deploying?) of the new packages.

Example of how to use the f32 and f64 flags:

@Ughuuu Ughuuu linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant