Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost get_io_service deprecated #13

Open
nandlab opened this issue Nov 17, 2021 · 1 comment
Open

Boost get_io_service deprecated #13

nandlab opened this issue Nov 17, 2021 · 1 comment

Comments

@nandlab
Copy link

nandlab commented Nov 17, 2021

Hello Dimitry,
thanks for sharing this C++ firmata library!
Some boost functions you used deprecated and it did not compile. I forked this repository to https://github.com/NANDLAB/firmata and fixed it. I can create a pull request if you want.

I changed

port_.get_io_service().reset();
port_.get_io_service().run_one();

to

asio::io_context& ioc = static_cast<asio::io_service&>(port_.get_executor().context());
ioc.restart();
ioc.run_one();
@dimitry-ishenko
Copy link
Collaborator

Thanks for the heads-up. I will try to get to it to fix things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants