Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 5.1 #1487

Closed
payamnj opened this issue Aug 10, 2024 · 4 comments
Closed

Add support for Django 5.1 #1487

payamnj opened this issue Aug 10, 2024 · 4 comments

Comments

@payamnj
Copy link
Contributor

payamnj commented Aug 10, 2024

Django releasad minor version 5.1, and the latest version of django-filer is not compatible with this new version.

@fsbraun
Copy link
Member

fsbraun commented Aug 10, 2024

Hi @payamnj !

django-filer does support django 5.1, but at this point the latest easy-thumbnails release does not.

@marksweb's #1476 will remove the pin to Django<5.1 as soon as easy-thumbnails latest release works with django 5.1. It is currently there as a safeguard.

As for easy-thumbnails, the django 5.1 support (SmileyChris/easy-thumbnails#626) was merged two weeks ago, and I am positive that we'll see a release of this soon. (@SmileyChris: Do you have any ETA?)

Let's not forget, all these repositories are maintained by their contributors for free, mostly in their spare time. Hence I ask you to bear with us.

@payamnj
Copy link
Contributor Author

payamnj commented Aug 10, 2024

I see! Thank you very much for the information.

@payamnj payamnj closed this as completed Aug 10, 2024
@MarcoGlauser
Copy link

MarcoGlauser commented Sep 9, 2024

Sorry for continuing this closed issue.
@fsbraun Judging from the easy-thumbnails changelog, the linked PR was released back in July.
https://github.com/SmileyChris/easy-thumbnails/blob/master/CHANGES.rst
Any chance of removing the <5.1 pin? :)

@fsbraun
Copy link
Member

fsbraun commented Sep 9, 2024

@MarcoGlauser Thanks for drawing my attention to the fact that the fix by now has been released. The filer PR is merged and 3.2.2 is out just now: no more pinning to Django<5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants