Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing buttons are cut off in filer field #1499

Open
krmax44 opened this issue Sep 23, 2024 · 6 comments
Open

Editing buttons are cut off in filer field #1499

krmax44 opened this issue Sep 23, 2024 · 6 comments

Comments

@krmax44
Copy link

krmax44 commented Sep 23, 2024

The Filer File Fields are cut off in CMS editing modals. This seems to be due to absolute positioning of the elements.

image

When disabling position: absolute in the dev tools, it looks like this:

image

@fsbraun
Copy link
Member

fsbraun commented Sep 23, 2024

@krmax44 Thanks for reporting this. What styling are you using for the admin, e.g. plain Django, djangocms-admin-style, or anything else?

Which css file does the position: absolute belong to?

@krmax44
Copy link
Author

krmax44 commented Sep 26, 2024

It's plain Django. Seems to be this one:

.filerFile {
position: absolute;

@fsbraun
Copy link
Member

fsbraun commented Sep 26, 2024

@krmax44 I think the actual solution will lie elsewhere. Removing the position will enlargen the widget. It should fit into the space, however.

The result should probably look like this:
image

Also the relatively new "View" icon (eye) should be properly formatted.

@krmax44
Copy link
Author

krmax44 commented Sep 26, 2024

Yes, the elements should be besides each other. I think this should be a flexbox layout, not absolutely positioned. Simply adding display: flex to .filerFile goes a long way already.
image

@fsbraun
Copy link
Member

fsbraun commented Sep 26, 2024

Yes, that might be an interesting direction to pursue. I think flexbox did not exist when the original css was created...

@gradel
Copy link

gradel commented Oct 28, 2024

for my setup (custom feincms3 plugin) this css did the trick:

form .form-row .filer-dropzone span.filerFile.js-file-selector > a:first-child {
    padding-top: 0 !important;
    float: left;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants