Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version admin contains a link to unpublish #165

Open
jonathan-s opened this issue Oct 15, 2019 · 1 comment
Open

The version admin contains a link to unpublish #165

jonathan-s opened this issue Oct 15, 2019 · 1 comment

Comments

@jonathan-s
Copy link
Contributor

When a model is moderated any unpublishing should also be moderated. Right now the versioning admin contains a link to unpublish content. Ideally this should be removed when a model is moderated.

When cms_config is run we could potentially register a modified variant of VersionAdmin that doesn't contain the unpublishing link. A potential issue is the order in which the various cms_config is run. Depending on whether cms_config for versioning runs first the version admin might already be registered.

https://github.com/divio/djangocms-versioning/blob/master/djangocms_versioning/helpers.py#L79-L87

@fsbraun
Copy link
Member

fsbraun commented Nov 22, 2022

Would an alternative be to show VersionAdmin actions according to the check_unpublish (or all the other check_... properties)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants