Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shell completion continuous integration tests #11

Open
bckohan opened this issue Feb 19, 2024 · 0 comments
Open

Improve shell completion continuous integration tests #11

bckohan opened this issue Feb 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bckohan
Copy link
Member

bckohan commented Feb 19, 2024

The strategy for testing completion functionality is to run the various shells behind a python psuedo terminal. This works for bash and zshell but does not work for fish or powershell. Right now only install/remove are tested in the CI for fish and powershell. There are also intermittent spurious failures on the bash and zshell tests. There must be a more stable way to test this functionality in an integrated end-to-end way that works for all shells and is deterministic. I would also like to add windows tests.

Until such time as a solution is identified, if changes to shells or the library are made it is best to manually test the fish and powershell completion still works before issuing releases.

This is somewhat ameliorated by shell completion being a nice to have and not a critical feature that prevents using the library.

@bckohan bckohan added the enhancement New feature or request label Feb 19, 2024
@bckohan bckohan self-assigned this Feb 19, 2024
@bckohan bckohan changed the title Improve completion continuous integration tests Improve shell completion continuous integration tests Feb 19, 2024
@bckohan bckohan added this to the Version 1.3 milestone Apr 23, 2024
@bckohan bckohan modified the milestones: Version 2.2, Version 3.0 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant