-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommentFlag incompatible with user-defined comment model #1
Comments
One possible solution is to allow the definition of a custom |
5 years later, still no fix. |
@zmrenwu this is a volunteer project. If this issue is has not been fixed in the last 5 years it's probably because it was not considered critical enough for someone to dedicate time fixing it. If it is to you I encourage you to give a try at submitting a patch for it. Complaining about unresolved issues without providing a solution is not going to get it fixed by itself or encourage someone to work towards it. |
Sorry, I don't mean to complain, just a banter. I encounter this issue recently. I am trying to fix it. But if an issue haven't have any responses and discussions for 5 years, I doubt if it will be reviewed or merged by the maintainer. |
As an example, in models.py:
If we set this as our model, by overriding
get_model
andCommentForm.get_comment_model
we can create comments fine, but if we try to delete them, we get this error:The only way I can think of to avoid this issue is to completely rewrite
CommentFlag
and the deletion method, thus pretty much reinventing the wheel.The text was updated successfully, but these errors were encountered: