Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated comments still send the comment_was_posted signal #107

Open
ghost opened this issue Oct 13, 2016 · 2 comments
Open

Duplicated comments still send the comment_was_posted signal #107

ghost opened this issue Oct 13, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 13, 2016

django_comments return the previews comment if it checked a duplicated comments. This would result in sending the comment_was_posted signal twice. These would get some unexpective results. For example, if I send a notification in comment_was_posted, then user will receive two notifications even there is only one comment. What do you think about this issue? If you think it is nesessary to fix it. I will make a pull requests.

@ghost
Copy link
Author

ghost commented Oct 13, 2016

In addition, do you have any plan convert the view to class based view? If we do this, people can overide a few methods then they can fix the above issue.

@claudep
Copy link
Member

claudep commented Oct 13, 2016

If you can provide a patch with an appropriate test, it will be welcome.

About class-based-views, this is #82. It seems however the poster was short of time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant