Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for 1.8.2 #80

Closed
dkackman opened this issue Jul 28, 2023 · 8 comments
Closed

Support for 1.8.2 #80

dkackman opened this issue Jul 28, 2023 · 8 comments
Assignees
@dkackman
Labels
help wanted Extra attention is needed

Comments

@dkackman
Copy link
Owner

dkackman commented Jul 28, 2023 •
edited
Loading

Update the apis to support the 1.8.2 changes.

Since the last release was https://github.com/dkackman/chia-dotnet/releases/tag/v1.4.0 this issue categorizes changes from there to present (1.8.2 as of this writing). Specific blocks of work are below with detail.

The majority of the work is rote, involving using the SendMessage methods in the ServiceProxy base class to thunk from dynamic to static types.

Collections, static types, and tuples require slightly different approaches.

The DocFx documentation is a good starting place for seeing the core static structure and exciting api types and signatures
@dkackman dkackman self-assigned this Jul 28, 2023
@dkackman
Copy link
Owner Author

dkackman commented Jul 28, 2023 •
edited
Loading

Data layer:
https://github.com/dkackman/chia-api/blob/main/src/data_layer.yaml

  • Done

@dkackman dkackman added the help wanted Extra attention is needed label Jul 28, 2023
@dkackman
Copy link
Owner Author

crawler api

  • No changes

@dkackman
Copy link
Owner Author

farmer api

  • no changes

@dkackman
Copy link
Owner Author

dkackman commented Jul 28, 2023 •
edited
Loading

daemon api

  • get_key
  • get_keys
  • set_label
  • delete_label

@dkackman
Copy link
Owner Author

dkackman commented Jul 28, 2023 •
edited
Loading

full_node api
https://github.com/dkackman/chia-api/blob/main/src/full_node.yaml

  • get_block_spends
  • get_blocks (new parameters)
  • get_mempool_item_by_tx_id (include_pending)
  • get_fee_estimate

@dkackman
Copy link
Owner Author

dkackman commented Jul 28, 2023 •
edited
Loading

wallet api
https://github.com/dkackman/chia-api/blob/main/src/wallet.yaml

  • All of the DTO types will be added at once and merged to main.
  • create_new_dl
  • dl_track_new
  • dl_stop_tracking
  • dl_latest_singleton
  • dl_singletons_by_root
  • dl_update_root
  • dl_update_multiple
  • dl_history
  • dl_owned_singletons
  • dl_get_mirrors
  • dl_new_mirror
  • dl_delete_mirror
  • nft_mint_bulk
  • nft_mint_nft (replace series w edition, reuse_puzhash)
  • nft_get_nfts (new params)
  • nft_set_nft_did (reuse_puzhash)
  • nft_transfer_nft (reuse_puzhash)
  • nft_calculate_royalties
  • nft_get_info (new params)
  • nft_add_uri (new params)
  • did_transfer_did (new params)
  • did_update_recovery_ids (new params)
  • did_get_wallet_name (missing result field in yaml "name")
  • did_update_metadata (reuse_puzhash)
  • take_offer (new params)
  • cancel_offers
  • select_coins (new params)
  • check_offer_validity (new result field)
  • get_offer_summary (new params and result fields)
  • create_offer_for_ids (new params)
  • cat_spend (new params)
  • add_rate_limited_funds - remove
  • rl_set_user_info - remove
  • send_clawback_transaction (remove)
  • get_current_derivation_index
  • extend_derivation_index
  • create_signed_transaction (new params)
  • send_transaction (new params)
  • get_wallet_balances
  • get_spendable_coins
  • get_transactions (new params)
  • get_transaction_count (new params)
  • push_transactions
  • delete_notifications
  • send_notification
  • sign_message_by_address
  • sign_message_by_id
  • get_coin_records_by_names
  • get_coin_records
  • verify_signature
  • get_wallets (new result field)
  • create_new_wallet (remove rl stuff)
  • did_message_spend
  • did_get_info
  • did_find_lost_did
  • nft_set_did_bulk
  • nft_transfer_bulk
  • get_timestamp_for_height
  • set_wallet_resync_on_startup
  • get_transaction_memo
  • nft_count_nfts
  • set_auto_claim
  • get_auto_claim
  • spend_clawback_coins
  • vc_mint
  • vc_get
  • vc_get_list
  • vc_spend
  • vc_add_proofs
  • vc_get_proofs_for_root
  • vc_revoke

@dkackman
Copy link
Owner Author

dkackman commented Jul 28, 2023 •
edited
Loading

Type differences

WIP in this branch
https://github.com/dkackman/chia-dotnet/tree/dto

  • run through the various data types declared in the yaml schemas and ChiaTypes stuff (somewhere I had a script for this - I think)

@dkackman dkackman mentioned this issue Jul 30, 2023
Merged
@dkackman dkackman pinned this issue Jul 30, 2023
This was referenced Aug 1, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dkackman
Copy link
Owner Author

dkackman commented Aug 11, 2023 •
edited
Loading

Add/update/fix unit tests:

  • ServiceProxy
  • FarmerProxy
  • Bech32
  • Conversions
  • Serialization
  • PlotterConfig
  • CrawlerProxy
  • DaemonProxy
  • HarvesterProxy
  • PlotterProxy
  • FullNodeProxy
  • WalletProxy
  • DataLayerProxy
  • Wallet
  • CATWallet
  • PoolWallet
  • DIDWallet
  • NFTWallet
  • DataLayerWallet
  • TradeManager
  • VerfifiedCredenmtialManager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkackman dkackman

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkackman