Skip to content
This repository has been archived by the owner on Nov 23, 2019. It is now read-only.

Response status code needs to be checked after unauthorized #138

Open
stevvooe opened this issue Mar 8, 2016 · 1 comment
Open

Response status code needs to be checked after unauthorized #138

stevvooe opened this issue Mar 8, 2016 · 1 comment

Comments

@stevvooe
Copy link
Contributor

stevvooe commented Mar 8, 2016

Please see this code: https://github.com/docker/engine-api/blob/master/client/image_pull.go#L30. The status code is not checked after running privilegeFunc. This could return a completely invalid body and result in undetectable error.

I'm not sure about a fix since it is not entirely clear what this code is supposed to be doing. Why wouldn't privilegeFunc be called on the first time through?

@coreydaley
Copy link

Looks like it's on line 35 now, and still exists in https://github.com/moby/moby/blob/master/client/image_pull.go

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants