Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add CDNJS to download page? #13

Open
PeterDaveHello opened this issue Mar 19, 2016 · 4 comments
Open

Is it possible to add CDNJS to download page? #13

PeterDaveHello opened this issue Mar 19, 2016 · 4 comments

Comments

@PeterDaveHello
Copy link

Hi there,

I'm the CDNJS maintainer Peter, I wonder if you would like to add CDNJS on the download page just like Google CDN, so that your users can have one more choice, this is the page of dojo on CDNJS:
https://cdnjs.com/libraries/dojo

Thank you.

Best,
Peter

@kfranqueiro
Copy link
Member

I'm not sure whether this presents a problem, but I'd point out that it appears there is a small difference between CDNJS's build and Google CDN's.

Looking at dojo.js.uncompressed.js, CDNJS has defaultConfig seeded with async:0 and does not have 'dojo-cdn' set in hasCache. Google CDN has async:"legacyAsync" and 'dojo-cdn':1 in hasCache.

Both of these are set in util/buildscripts/profiles/cdn.profile.js which is normally used to build the CDN distribution.

I poked a few simple test cases (including one using legacy dojo.require) and it didn't seem to stop it from working, so maybe this isn't important. Unfortunately my memory is fuzzy on what specifically the dojo-cdn has flag was solving.

@PeterDaveHello
Copy link
Author

Hi @kfranqueiro, the build on CDNJS was downloaded from official website. Is there anything I need to fix?

@kfranqueiro
Copy link
Member

I just poked through Dojo's release script. Builds specifically for CDNs get posted to http://archive.dojotoolkit.org/cdn/, so you probably want to host the files from the zips there instead.

Note that some old versions prior to 1.7 were packaged differently and specific to each CDN, though I'm not sure you're concerned with releases that old anyway.

@PeterDaveHello
Copy link
Author

@kfranqueiro I'm very sorry for my late reply, and thanks for your help, I'm wondering if there is a git repo or npm package can serve these files? CDNJS currently supports the auto-update mechanism from git repo or npm package, if we can fetch the updates from one of them, we don't need manually update dojo on CDNJS anymore, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants