Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply is not shown #349

Open
Basskrapfen opened this issue Feb 22, 2024 · 14 comments
Open

Reply is not shown #349

Basskrapfen opened this issue Feb 22, 2024 · 14 comments

Comments

@Basskrapfen
Copy link

Basskrapfen commented Feb 22, 2024

Hi,

when I reply to a discussion post, the reply is not shown on the page. On the admin (moderation) page, the reply is visible though.
Any ideas how I could fix this?

DokuWiki version is "Jack Jackrum", threads are enabled, installed plugin is "2021-12-31" which is the latest which is available via the extension manager.

I couldn't find any messages/errors in the dokuwiki log file.

Thanks a lot!

@pblahman
Copy link

I also have this issue with PHP 7.4 or PHP 8.2 and Release 2024-02-06a "Kaos". However deprecation log indicates lots of this:
2024-02-25 09:11:12ptln() is deprecated. It was called from admin_plugin_discussion::html() in /home/sctxcompclubora/sctxcompclub.net/lib/plugins/discussion/admin.php:74 echo should be used instead!
I have been "looking" for ptln documentation. Which "might" give me a clue about how to change ptln to echo.

@tomnbw
Copy link

tomnbw commented Feb 29, 2024

Hello,

I'd like to bring to your attention a bug that has emerged after the recent update of the Discussion plugin. Following the update, replies to comments are no longer visible on the page. While these replies can still be seen in the pending comments section for review, they aren't being publicly displayed. This issue has arisen recently and wasn't present in another wiki where the Discussion plugin was installed quite some time ago. Interestingly, after reinstalling the Discussion plugin, the same issue occurred in the other wiki as well.

Additionally, I have a small request. Could you kindly consider either removing the ability for regular users to edit, hide, or delete their own comments, or making these permissions optional? Your assistance is greatly appreciated, and I extend my gratitude for your efforts.

Best regards

@pblahman
Copy link

pblahman commented Feb 29, 2024 via email

@pblahman
Copy link

pblahman commented Feb 29, 2024 via email

@tomnbw
Copy link

tomnbw commented Mar 2, 2024

Hi,

when I reply to a discussion post, the reply is not shown on the page. On the admin (moderation) page, the reply is visible though.

Any ideas how I could fix this?

DokuWiki version is "Jack Jackrum", threads are enabled, installed plugin is "2021-12-31" which is the latest which is available via the extension manager.

I couldn't find any messages/errors in the dokuwiki log file.

Thanks a lot!

Excuse me, have you found a solution to the problem with the report?

@KanenasPL
Copy link

@Basskrapfen
Copy link
Author

Hi,
when I reply to a discussion post, the reply is not shown on the page. On the admin (moderation) page, the reply is visible though.
Any ideas how I could fix this?
DokuWiki version is "Jack Jackrum", threads are enabled, installed plugin is "2021-12-31" which is the latest which is available via the extension manager.
I couldn't find any messages/errors in the dokuwiki log file.
Thanks a lot!

Excuse me, have you found a solution to the problem with the report?

Sorry, I couldn't find any solution or workaround yet.

@wlfram
Copy link

wlfram commented May 24, 2024

are there any news on this topic?

@luffah
Copy link

luffah commented Jun 13, 2024

@Basskrapfen there is a simple editing error in action.php:956 .

The condition is inverted.

        if (empty($comment['replies'])) {
            return;
        }

@sataix
Copy link

sataix commented Jul 6, 2024

luffah is right, this immediately fixed the issue on my instance of DokuWiki. For ones who experience the same issue: change action.php:956 from if (!empty($comment['replies'])) to if (empty($comment['replies'])).

@mosely1
Copy link

mosely1 commented Jul 8, 2024

Confirmed this works. Unsure how it will affect future updates to the plugin. I'd make a pull request, but it seems they are not accepted. Simple fix, in case you need it.

@iatttmp
Copy link

iatttmp commented Dec 19, 2024

I have no idea how "action.php:956" tells me where to find the code to change.

@mosely1
Copy link

mosely1 commented Dec 19, 2024

It's line 956 of that file.

@iatttmp
Copy link

iatttmp commented Dec 19, 2024

Thanks. I should have thought of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants