Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CMake's FindPackage module to import zlib #15

Open
FlyingOE opened this issue Aug 11, 2023 · 1 comment
Open

Use CMake's FindPackage module to import zlib #15

FlyingOE opened this issue Aug 11, 2023 · 1 comment

Comments

@FlyingOE
Copy link

CMake's FindPackage module has been supporting ZLIB import since version 3.1. It's better to push CMake's version requirement from 3.0 to 3.1 and use FindPackage to import zlib instead.
@peeyee
Copy link
Collaborator

peeyee commented Aug 14, 2023

Sounds a good idea.

FlyingOE pushed a commit to FlyingOE/DolphinDBPlugin that referenced this issue Aug 15, 2023
implement dolphindb#15; restructured CMakeLists.txt to 3.x-style rules
e49fbc6
FlyingOE pushed a commit to FlyingOE/DolphinDBPlugin that referenced this issue Aug 15, 2023
implement dolphindb#15; restructured CMakeLists.txt to 3.x-style rules
0db5226
@FlyingOE FlyingOE mentioned this issue Aug 15, 2023
Merged
FlyingOE pushed a commit to FlyingOE/DolphinDBPlugin that referenced this issue Aug 21, 2023
fixed dolphindb#15 support for zlib Debug build
70a2ea0
FlyingOE pushed a commit to FlyingOE/DolphinDBPlugin that referenced this issue Aug 21, 2023
fixed dolphindb#15 support for zlib Debug build
c4a61c8
FlyingOE pushed a commit to FlyingOE/DolphinDBPlugin that referenced this issue Aug 21, 2023
fixed dolphindb#15 support for zlib Debug build
860e22f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FlyingOE @peeyee