You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unfortunately, it doesn't seem to be safe to call clone on an arbitrary three.js Object3D. As a result, creating a box shape fails if you try to create it on an object hierarchy that includes somewhere in it an Audio or PositionalAudioObject3D. For example, in a browser:
I don't know enough about three.js conventions to say whether three or this library is the one that is "wrong". One possible fix would be to write the bounding box creation code in question directly in terms of the matrices involved instead of calling clone, but it looks like that would be mostly duplicating a lot of code from Box3.
The text was updated successfully, but these errors were encountered:
mqp
changed the title
Error creating a box shape with a THREE.Audio in the tree
Error creating box shape with a THREE.Audio in the tree
Jul 26, 2018
mqp
changed the title
Error creating box shape with a THREE.Audio in the tree
Error creating box with a THREE.Audio in the tree
Jul 26, 2018
mqp
added a commit
to Hubs-Foundation/hubs
that referenced
this issue
Jul 26, 2018
Unfortunately, it doesn't seem to be safe to call
clone
on an arbitrary three.jsObject3D
. As a result, creating a box shape fails if you try to create it on an object hierarchy that includes somewhere in it anAudio
orPositionalAudio
Object3D
. For example, in a browser:will result in
This regressed recently with this commit: 0c7bc98
I don't know enough about three.js conventions to say whether three or this library is the one that is "wrong". One possible fix would be to write the bounding box creation code in question directly in terms of the matrices involved instead of calling
clone
, but it looks like that would be mostly duplicating a lot of code fromBox3
.The text was updated successfully, but these errors were encountered: