Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Removing reference to readme #52

Closed
wants to merge 1 commit into from
Closed

WIP: Removing reference to readme #52

wants to merge 1 commit into from

Conversation

rodoufu
Copy link

@rodoufu rodoufu commented Jun 12, 2020

Closes: #51

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #52 into master will decrease coverage by 21.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #52       +/-   ##
===========================================
- Coverage   77.29%   56.00%   -21.30%     
===========================================
  Files          18       18               
  Lines         740     1016      +276     
===========================================
- Hits          572      569        -3     
- Misses        168      447      +279     
Impacted Files Coverage Δ
dotenv/src/parse.rs 43.18% <0.00%> (-26.62%) ⬇️
dotenv/src/lib.rs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d15856...88676f2. Read the comment docs.

@Plecra
Copy link
Contributor

Plecra commented Jun 26, 2020

I'm pretty sure we still want cargo to know about the README 😅 It's part of the crate's documentation, and can't just be thrown out like that. How about we follow serde's example and use a symlink?

@rodoufu
Copy link
Author

rodoufu commented Jun 26, 2020

I'm pretty sure we still want cargo to know about the README It's part of the crate's documentation, and can't just be thrown out like that. How about we follow serde's example and use a symlink?

It was breaking the build in a cargo +nightly version.

@rodoufu rodoufu closed this Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build dotenv v0.15.0
2 participants